Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shared_preferences] Add test to enforce mutable lists #7369

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

tarrinneal
Copy link
Contributor

@tarrinneal tarrinneal commented Aug 12, 2024

Just a test :)

@tarrinneal tarrinneal marked this pull request as ready for review August 12, 2024 08:10
@tarrinneal tarrinneal changed the title Add test to enforce mutable lists [shared_preferences] Add test to enforce mutable lists Aug 12, 2024
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 27, 2024
@auto-submit auto-submit bot merged commit bcb09db into flutter:main Aug 27, 2024
76 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 28, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 28, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 29, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 29, 2024
flutter/packages@d862279...2a0f254

2024-08-28 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds internal wrapper for remaining methods of the Android native `AdsManager`  (flutter/packages#7437)
2024-08-28 brackenavaron@gmail.com [shared_preferences] Fix typo in changelog (flutter/packages#7523)
2024-08-27 matanlurey@users.noreply.github.com Remove matan from codeowners (flutter/packages#7511)
2024-08-27 tarrinneal@gmail.com [shared_preferences] Add test to enforce mutable lists (flutter/packages#7369)
2024-08-27 magder@google.com [google_sign_in_ios] Fix "callee requires a non-null parameter" analyzer warning (flutter/packages#7513)
2024-08-27 louisehsu@google.com [in_app_purchase_storekit] Allows 'localizedDescription' to be nullable to handle occasional nulls in Storekit objects (flutter/packages#7515)
2024-08-27 31859944+LongCatIsLooong@users.noreply.github.com Cupertino icons golden tests (flutter/packages#7421)
2024-08-26 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 2.0.10 to 2.0.20 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#7500)
2024-08-26 zezohassam@gmail.com [video_player] Updates minimum supported SDK (flutter/packages#7498)
2024-08-26 paulberry@google.com [url_launcher] Ignore new `unreachable_switch_default` warning. (flutter/packages#7487)
2024-08-26 linxunfeng@yeah.net Revert "[video_player] Relands #6456: Uses SurfaceProducer, this time with setCallback for suspend/resume lifecycles" (flutter/packages#7497)
2024-08-24 matanlurey@users.noreply.github.com [video_player] Relands #6456: Uses `SurfaceProducer`, this time with `setCallback` for suspend/resume lifecycles. (flutter/packages#6989)
2024-08-23 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_android] Convert `PlatformTileOverlay` to Pigeon (flutter/packages#7467)
2024-08-23 47866232+chunhtai@users.noreply.github.com [go_router] Fixes issue so that the parseRouteInformationWithContext � (flutter/packages#7337)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
flutter/packages@d862279...2a0f254

2024-08-28 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds internal wrapper for remaining methods of the Android native `AdsManager`  (flutter/packages#7437)
2024-08-28 brackenavaron@gmail.com [shared_preferences] Fix typo in changelog (flutter/packages#7523)
2024-08-27 matanlurey@users.noreply.github.com Remove matan from codeowners (flutter/packages#7511)
2024-08-27 tarrinneal@gmail.com [shared_preferences] Add test to enforce mutable lists (flutter/packages#7369)
2024-08-27 magder@google.com [google_sign_in_ios] Fix "callee requires a non-null parameter" analyzer warning (flutter/packages#7513)
2024-08-27 louisehsu@google.com [in_app_purchase_storekit] Allows 'localizedDescription' to be nullable to handle occasional nulls in Storekit objects (flutter/packages#7515)
2024-08-27 31859944+LongCatIsLooong@users.noreply.github.com Cupertino icons golden tests (flutter/packages#7421)
2024-08-26 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 2.0.10 to 2.0.20 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#7500)
2024-08-26 zezohassam@gmail.com [video_player] Updates minimum supported SDK (flutter/packages#7498)
2024-08-26 paulberry@google.com [url_launcher] Ignore new `unreachable_switch_default` warning. (flutter/packages#7487)
2024-08-26 linxunfeng@yeah.net Revert "[video_player] Relands flutter#6456: Uses SurfaceProducer, this time with setCallback for suspend/resume lifecycles" (flutter/packages#7497)
2024-08-24 matanlurey@users.noreply.github.com [video_player] Relands flutter#6456: Uses `SurfaceProducer`, this time with `setCallback` for suspend/resume lifecycles. (flutter/packages#6989)
2024-08-23 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_android] Convert `PlatformTileOverlay` to Pigeon (flutter/packages#7467)
2024-08-23 47866232+chunhtai@users.noreply.github.com [go_router] Fixes issue so that the parseRouteInformationWithContext � (flutter/packages#7337)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: shared_preferences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants